Skip to content

bundle: filter VSCode server chatter#22396

Merged
MikeMcQuaid merged 1 commit into
mainfrom
bundle-vscode-extension-filter
May 24, 2026
Merged

bundle: filter VSCode server chatter#22396
MikeMcQuaid merged 1 commit into
mainfrom
bundle-vscode-extension-filter

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

  • ignore VSCode server progress output during extension dumps
  • keep only extension-shaped identifiers in Brewfile output

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


- ignore VSCode server progress output during extension dumps
- keep only extension-shaped identifiers in Brewfile output
Copilot AI review requested due to automatic review settings May 23, 2026 17:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves brew bundle dump --vscode resilience by filtering out non-extension “chatter” that can appear in code --list-extensions output (e.g., VSCode server setup/progress lines), ensuring Brewfile output contains only valid extension identifiers.

Changes:

  • Add an EXTENSION_ID_REGEX and filter --list-extensions output to keep only extension-shaped IDs (after stripping whitespace).
  • Add an RSpec case covering VSCode server setup/progress output mixed into the extension list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/bundle/extensions/vscode_extension.rb Filters code --list-extensions output to only retain valid extension identifiers, reducing noisy/non-extension lines in dumps.
Library/Homebrew/test/bundle/vscode_extension_spec.rb Adds test coverage ensuring server/progress output is ignored and only real extension IDs are returned.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue May 24, 2026
Merged via the queue into main with commit 75d792b May 24, 2026
77 of 81 checks passed
@MikeMcQuaid MikeMcQuaid deleted the bundle-vscode-extension-filter branch May 24, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants