bundle: filter VSCode server chatter#22396
Merged
Merged
Conversation
- ignore VSCode server progress output during extension dumps - keep only extension-shaped identifiers in Brewfile output
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves brew bundle dump --vscode resilience by filtering out non-extension “chatter” that can appear in code --list-extensions output (e.g., VSCode server setup/progress lines), ensuring Brewfile output contains only valid extension identifiers.
Changes:
- Add an
EXTENSION_ID_REGEXand filter--list-extensionsoutput to keep only extension-shaped IDs (after stripping whitespace). - Add an RSpec case covering VSCode server setup/progress output mixed into the extension list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/bundle/extensions/vscode_extension.rb | Filters code --list-extensions output to only retain valid extension identifiers, reducing noisy/non-extension lines in dumps. |
| Library/Homebrew/test/bundle/vscode_extension_spec.rb | Adds test coverage ensuring server/progress output is ignored and only real extension IDs are returned. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlocab
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review and testing.