Upload coverage to GitHub#22451
Open
MikeMcQuaid wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Surfaces brew tests --coverage results in GitHub pull requests by uploading the existing Cobertura coverage report to GitHub's code coverage feature, alongside the existing Codecov upload.
Changes:
- Add job-level permissions (
code-quality: write,pull-requests: read) to thetestsjob in.github/workflows/tests.yml. - Add an
actions/upload-code-coverage@v1step that uploads the existingcoverage.xmlto GitHub code coverage. - Add a path-specific actionlint ignore for the unknown
code-qualitypermission scope until actionlint recognises it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/tests.yml | Adds job permissions and a step to upload the Cobertura report to GitHub code coverage. |
| .github/actionlint.yaml | Suppresses actionlint's unknown-scope warning for code-quality in tests.yml. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Surface `brew tests --coverage` results in GitHub pull requests. - Reuse the existing Cobertura report uploaded to Codecov. - Allow `code-quality` until actionlint recognises the new scope.
MikeMcQuaid
force-pushed
the
add-github-coverage-upload
branch
from
86692fc to
3422894
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew tests --coverageresults in GitHub pull requests.code-qualityuntil actionlint recognises the new scope.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review.