test/cmd/update_spec: fix local test run failures#22906
Merged
Conversation
`brew tests` is a developer command so running it triggers HOMEBREW_DEV_CMD_RUN and causes failures for some tests set up for stable brew tags.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Library/Homebrew/test/cmd/update_spec.rb resilient to being executed in an environment where HOMEBREW_DEV_CMD_RUN is set (e.g. when running the test suite via the developer command brew tests). It ensures the update script behaves as the specs expect (stable-tag update behavior) when spawned via Open3.capture3.
Changes:
- Explicitly unset
HOMEBREW_DEV_CMD_RUNin the environment passed torun_update_shellfor the affected examples. - Prevents unexpected
curlrequests to.../commits/mainduring these tests whenHOMEBREW_DEV_CMD_RUNwould otherwise be inherited.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bo98
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew testsis a developer command so running it triggers HOMEBREW_DEV_CMD_RUN and causes failures for some tests set up for stable brew tags.Mainly to allow running tests locally for development purposes. Otherwise can see failures like following (at least in Linux container):
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?