os/mac/mach: avoid delegate for dylib_id#22924
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Homebrew’s macOS Mach-O Pathname shim to avoid using delegate (which interferes with portable Ruby/Sorbet RBI generation on Linux) and to give MachOShim#dylib_id a stable String return type for typechecking and callers that expect string semantics.
Changes:
- Remove the
delegate-generateddylib_idmethod and defineMachOShim#dylib_idexplicitly inos/mac/mach.rb. - Adjust the Tapioca-generated DSL RBI for
MachOShimto no longer declare a dynamicdylib_idmethod stub.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/sorbet/rbi/dsl/mach_o_shim.rbi | Updates the generated DSL RBI to reflect that MachOShim no longer exposes dylib_id via a dynamic/delegated method. |
| Library/Homebrew/os/mac/mach.rb | Replaces delegate with an explicit dylib_id method implementation and signature to improve cross-platform typechecking behavior. |
Files not reviewed (1)
- Library/Homebrew/sorbet/rbi/dsl/mach_o_shim.rbi: File type not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Delegate causes issues for portable Ruby testing as running `brew typecheck --update` on Linux will remove the RBI file causing `brew typecheck` failures.
Bo98
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delegate causes issues for portable Ruby testing as running
brew typecheck --updateon Linux will remove the RBI file causingbrew typecheckfailures.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?