Adjust Subversion checkout operands#22942
Merged
Merged
Conversation
- Keep `svn checkout` option parsing separate from repository operands. - Cover the multi-revision checkout path to preserve that ordering.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts how svn checkout arguments are constructed in SubversionDownloadStrategy to ensure option parsing stays separate from repository operands, and adds a regression test that exercises the multi-revision checkout path (including externals) to preserve the intended ordering.
Changes:
- Reorder
svn checkoutarguments to place options first and terminate option parsing with--before the URL and target. - Add a spec covering
:revisions(trunk + externals) to assert checkout operands remain after options, including when an external URL could be interpreted as an option.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/download_strategy/subversion_download_strategy.rb | Moves svn checkout to ["checkout", *options, "--", url, target] to prevent operands being misparsed as options (or vice versa). |
| Library/Homebrew/test/download_strategies/subversion_spec.rb | Adds coverage for :revisions checkout to lock in the corrected operand/option ordering for trunk and externals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cho-m
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svn checkoutoption parsing separate from repository operands.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.