Skip to content

Adjust Subversion checkout operands#22942

Merged
MikeMcQuaid merged 1 commit into
mainfrom
subversion-checkout-operands
Jul 4, 2026
Merged

Adjust Subversion checkout operands#22942
MikeMcQuaid merged 1 commit into
mainfrom
subversion-checkout-operands

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Keep svn checkout option parsing separate from repository operands.
  • Cover the multi-revision checkout path to preserve that ordering.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


- Keep `svn checkout` option parsing separate from repository operands.
- Cover the multi-revision checkout path to preserve that ordering.
Copilot AI review requested due to automatic review settings July 4, 2026 13:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adjusts how svn checkout arguments are constructed in SubversionDownloadStrategy to ensure option parsing stays separate from repository operands, and adds a regression test that exercises the multi-revision checkout path (including externals) to preserve the intended ordering.

Changes:

  • Reorder svn checkout arguments to place options first and terminate option parsing with -- before the URL and target.
  • Add a spec covering :revisions (trunk + externals) to assert checkout operands remain after options, including when an external URL could be interpreted as an option.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/download_strategy/subversion_download_strategy.rb Moves svn checkout to ["checkout", *options, "--", url, target] to prevent operands being misparsed as options (or vice versa).
Library/Homebrew/test/download_strategies/subversion_spec.rb Adds coverage for :revisions checkout to lock in the corrected operand/option ordering for trunk and externals.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid enabled auto-merge July 4, 2026 13:09
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 4, 2026
Merged via the queue into main with commit 7ff4fd7 Jul 4, 2026
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the subversion-checkout-operands branch July 4, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants