Prepare cask taps before bundle jobs#22943
Merged
Merged
Conversation
- Fully qualified casks can need their tap before dependency discovery. - Loading those deps before scheduling avoids parallel lock races. - Cover the `tmuxpack/tpack/tpack` cask path from issue #22899.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts brew bundle’s parallel installer to proactively install taps for fully-qualified cask (and formula) entries before dependency discovery, avoiding parallel lock races and ensuring dependency resolution can load tapped casks correctly.
Changes:
- Ensure taps for fully-qualified Brew/Cask entries are installed before building the dependency graph.
- Add/update RSpec coverage to verify tap installation happens before cask dependency resolution in parallel runs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/bundle/parallel_installer.rb | Pre-installs required taps for fully-qualified cask/formula entries before dependency discovery and scheduling parallel jobs. |
| Library/Homebrew/test/bundle/installer_spec.rb | Adds stubs and a new example to assert tap installation precedes cask dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22899
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.