Skip to content

Prepare cask taps before bundle jobs#22943

Merged
MikeMcQuaid merged 1 commit into
mainfrom
fix-bundle-cask-tap-deps
Jul 4, 2026
Merged

Prepare cask taps before bundle jobs#22943
MikeMcQuaid merged 1 commit into
mainfrom
fix-bundle-cask-tap-deps

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Fully qualified casks can need their tap before dependency discovery.
  • Loading those deps before scheduling avoids parallel lock races.

Fixes #22899


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.5 xhigh with local review and testing.


- Fully qualified casks can need their tap before dependency discovery.
- Loading those deps before scheduling avoids parallel lock races.
- Cover the `tmuxpack/tpack/tpack` cask path from issue #22899.
Copilot AI review requested due to automatic review settings July 4, 2026 13:18
@MikeMcQuaid MikeMcQuaid enabled auto-merge July 4, 2026 13:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adjusts brew bundle’s parallel installer to proactively install taps for fully-qualified cask (and formula) entries before dependency discovery, avoiding parallel lock races and ensuring dependency resolution can load tapped casks correctly.

Changes:

  • Ensure taps for fully-qualified Brew/Cask entries are installed before building the dependency graph.
  • Add/update RSpec coverage to verify tap installation happens before cask dependency resolution in parallel runs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/bundle/parallel_installer.rb Pre-installs required taps for fully-qualified cask/formula entries before dependency discovery and scheduling parallel jobs.
Library/Homebrew/test/bundle/installer_spec.rb Adds stubs and a new example to assert tap installation precedes cask dependency resolution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 4, 2026
Merged via the queue into main with commit ba6fb82 Jul 4, 2026
43 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-bundle-cask-tap-deps branch July 4, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew --jobs auto still (a bit) broken

3 participants