Skip to content

dev-cmd/test-bot: make --skip-recursive-dependents default#22950

Merged
MikeMcQuaid merged 1 commit into
mainfrom
test-bot-skip-recursive-dependents
Jul 5, 2026
Merged

dev-cmd/test-bot: make --skip-recursive-dependents default#22950
MikeMcQuaid merged 1 commit into
mainfrom
test-bot-skip-recursive-dependents

Conversation

@cho-m

@cho-m cho-m commented Jul 4, 2026

Copy link
Copy Markdown
Member

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

This PR makes --skip-recursive-dependents default as we have made indirect linkage into explicit dependencies. Something we've discussed before to reduce time to finish tests.

Added a deprecation period with --no flag in case there are any specific issues that are found either in Homebrew/core or external taps. If everything looks good, we can rip out the recursive dependents logic from test-bot

Partner PR to:


Looking at args.skip_recursive_dependents?.inspect, [no-] switch defaults to nil (though brew typecheck --update doesn't change test_bot_cmd.rbi) so adding nil handling logic.

Copilot AI review requested due to automatic review settings July 4, 2026 18:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates brew test-bot to treat “skip recursive dependents” as the default behavior, reflecting the shift from implicit to explicit dependencies and aiming to reduce overall test-bot runtime. It also introduces a tri-state flag handling path (true/false/nil) to support the new default behavior.

Changes:

  • Make --skip-recursive-dependents effectively default-on by treating an unset CLI value (nil) as true.
  • Update test-bot CLI option to a --[no-]skip-recursive-dependents switch to allow opting back into recursive dependents during a transition period.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
Library/Homebrew/test_bot/formulae_dependents.rb Defaults “skip recursive dependents” to enabled when the CLI flag is unset.
Library/Homebrew/dev-cmd/test-bot.rb Changes the CLI switch to --[no-]skip-recursive-dependents and marks it deprecated.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/dev-cmd/test-bot.rb
Comment thread Library/Homebrew/test_bot/formulae_dependents.rb Outdated
Comment thread Library/Homebrew/test_bot/formulae_dependents.rb Outdated
@cho-m cho-m force-pushed the test-bot-skip-recursive-dependents branch from abb8558 to 063b9ca Compare July 4, 2026 18:51
@cho-m cho-m requested a review from Copilot July 4, 2026 18:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread Library/Homebrew/test_bot/formulae_dependents.rb
Comment thread Library/Homebrew/test_bot/formulae_dependents.rb
Comment thread Library/Homebrew/dev-cmd/test-bot.rb
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 5, 2026
@MikeMcQuaid

Copy link
Copy Markdown
Member

Thanks!

Merged via the queue into main with commit 700b37f Jul 5, 2026
42 checks passed
@MikeMcQuaid MikeMcQuaid deleted the test-bot-skip-recursive-dependents branch July 5, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants