dev-cmd/test-bot: make --skip-recursive-dependents default#22950
Merged
Conversation
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates brew test-bot to treat “skip recursive dependents” as the default behavior, reflecting the shift from implicit to explicit dependencies and aiming to reduce overall test-bot runtime. It also introduces a tri-state flag handling path (true/false/nil) to support the new default behavior.
Changes:
- Make
--skip-recursive-dependentseffectively default-on by treating an unset CLI value (nil) astrue. - Update
test-botCLI option to a--[no-]skip-recursive-dependentsswitch to allow opting back into recursive dependents during a transition period.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Library/Homebrew/test_bot/formulae_dependents.rb | Defaults “skip recursive dependents” to enabled when the CLI flag is unset. |
| Library/Homebrew/dev-cmd/test-bot.rb | Changes the CLI switch to --[no-]skip-recursive-dependents and marks it deprecated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abb8558 to
063b9ca
Compare
MikeMcQuaid
approved these changes
Jul 5, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?This PR makes
--skip-recursive-dependentsdefault as we have made indirect linkage into explicit dependencies. Something we've discussed before to reduce time to finish tests.Added a deprecation period with
--noflag in case there are any specific issues that are found either in Homebrew/core or external taps. If everything looks good, we can rip out the recursive dependents logic from test-botPartner PR to:
Looking at
args.skip_recursive_dependents?.inspect,[no-]switch defaults to nil (thoughbrew typecheck --updatedoesn't change test_bot_cmd.rbi) so adding nil handling logic.