Skip to content

upgrade: Split deps and find older version better#22951

Merged
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
HaraldNordgren:dry-run-reinstall-dependency-status
Jul 5, 2026
Merged

upgrade: Split deps and find older version better#22951
MikeMcQuaid merged 1 commit into
Homebrew:mainfrom
HaraldNordgren:dry-run-reinstall-dependency-status

Conversation

@HaraldNordgren

@HaraldNordgren HaraldNordgren commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Group brew upgrade --dry-run dependencies into separate "Would install" and "Would upgrade" sections aligned with format_upgrade_summary, and read the installed version from the kegs so unlinked upgrades still show "old -> new".

Also stop the first dependency in the "Installing dependencies for" line from rendering bolder than the rest.

▶ brew upgrade --dry-run ffmpeg
...

==> Would install 11 dependencies for ffmpeg:
expat        2.8.2
meson        1.11.1
nasm         3.02
dav1d        1.5.3
libvmaf      3.2.0
libvpx       1.16.0
opus         1.6.1
sdl3         3.4.12
sdl2-compat  2.32.70
svt-av1      4.1.0
x265         4.2
==> Would upgrade 9 dependencies for ffmpeg:
ninja        1.10.2_1 -> 1.13.2
openssl@3    3.6.2    -> 3.6.3
readline     8.1.2    -> 8.3.3
sqlite       3.38.0   -> 3.53.3
xz           5.4.1    -> 5.8.3
lz4          1.9.4    -> 1.10.0
zstd         1.5.2    -> 1.5.7_1
python@3.14  3.7.1    -> 3.14.6
x264         r2854    -> r3222

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

Written by Claude Code and I iterated on in many times to get what I wanted.


@HaraldNordgren HaraldNordgren changed the title Split and columnize dry-run dependency listings upgrade: Split deps and find older version better Jul 4, 2026
@HaraldNordgren HaraldNordgren force-pushed the dry-run-reinstall-dependency-status branch 2 times, most recently from fcf0494 to e560d11 Compare July 4, 2026 22:48

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small suggested style tweak and needs to use upgrade to avoid brew update confusion.

Comment thread Library/Homebrew/test/cmd/install_spec.rb Outdated
Comment thread Library/Homebrew/install.rb Outdated
@HaraldNordgren HaraldNordgren force-pushed the dry-run-reinstall-dependency-status branch from e560d11 to 8aa6832 Compare July 5, 2026 09:04
@HaraldNordgren

Copy link
Copy Markdown
Contributor Author

@MikeMcQuaid Thanks, updated!

Group `brew upgrade --dry-run` dependencies into separate "Would install"
and "Would upgrade" sections aligned with format_upgrade_summary, and read
the installed version from the kegs so unlinked upgrades still show
"old -> new".

Also stop the first dependency in the "Installing dependencies for" line
from rendering bolder than the rest.
@HaraldNordgren HaraldNordgren force-pushed the dry-run-reinstall-dependency-status branch from 8aa6832 to 2b74170 Compare July 5, 2026 10:16

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jul 5, 2026
Merged via the queue into Homebrew:main with commit 275490f Jul 5, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants