Ignore same-name cask migrations#22955
Merged
Merged
Conversation
- Same-name cask-to-formula tap migrations are valid metadata. - Do not treat them as formula old names needing Cellar migration. - Prevent upgrade and reinstall from taking the formula lock twice. - Add a regression for the same-name cask-to-formula case. - Fixes #22948.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Formula#oldnames so that “same-name” tap migration metadata (notably cask-to-formula migrations where the token doesn’t change) is not treated as a formula rename requiring Cellar migration. This aligns the metadata handling with the intended semantics and avoids downstream behaviors that can lead to re-locking the same formula/Cellar path during upgrade/reinstall flows.
Changes:
- Filter
Formula#oldnamesto drop migration entries whose base name matches the current formula name. - Add a regression spec ensuring same-name cask-to-formula migrations do not contribute to
oldnames.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/formula.rb | Filters out “same-name” migration oldnames to avoid treating them as formula renames. |
| Library/Homebrew/test/formula_spec.rb | Adds a regression test covering the same-name cask-to-formula migration case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
p-linnane
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22948.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.