Skip to content

audit: fix full versioned alias name resolution in taps#2644

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
JCount:audit-fix-tap-versioned-aliases
May 20, 2017
Merged

audit: fix full versioned alias name resolution in taps#2644
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
JCount:audit-fix-tap-versioned-aliases

Conversation

@JCount
Copy link
Copy Markdown
Contributor

@JCount JCount commented May 17, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.

This can be done in one line, but it seemed less readable. I am happy to change it, however.

cc @MikeMcQuaid as this is a slight fix to his PR: #2619.

Fixes #2650.

This fixes an issue where audit would prompt for the creation
of an already existing versioned alias while at the same time
declaring the existing alias invalid.
@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label May 17, 2017
@JCount
Copy link
Copy Markdown
Contributor Author

JCount commented May 18, 2017

The bug that this is intended to fix is the one @javian reported in #2650.

@JCount JCount requested a review from MikeMcQuaid May 19, 2017 17:52
@MikeMcQuaid MikeMcQuaid merged commit a7c6a57 into Homebrew:master May 20, 2017
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @JCount!

@MikeMcQuaid MikeMcQuaid removed the in progress Maintainers are working on this label May 20, 2017
@JCount JCount deleted the audit-fix-tap-versioned-aliases branch May 20, 2017 11:32
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew audit falsely reports PHP tap aliases as incorrect

3 participants