cask audit: check for sourceforge appcast#4278
Merged
commitay merged 3 commits intoHomebrew:masterfrom Jun 7, 2018
commitay:audit-sourceforge-appcast
Merged
cask audit: check for sourceforge appcast#4278commitay merged 3 commits intoHomebrew:masterfrom commitay:audit-sourceforge-appcast
commitay merged 3 commits intoHomebrew:masterfrom
commitay:audit-sourceforge-appcast
Conversation
ghost
assigned
claui
suggested changes
Jun 5, 2018
Contributor
claui
left a comment
claui
left a comment
There was a problem hiding this comment.
Minor nitpicks for clarity and readability.
| return if cask.version.latest? | ||
| return unless cask.url.to_s =~ %r{sourceforge.net/(\S+)} | ||
|
|
||
| add_warning "Cask hosted on SourceForge, please add an appcast. See https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/appcast.md" |
Contributor
There was a problem hiding this comment.
Minor language tweak: Download is hosted on SourceForge to avoid confusion.
(Adding the is would be just for consistency with the GitHub warning, which is also a complete sentence.)
| describe "SourceForge appcast check" do | ||
| let(:error_msg) { /Cask hosted on SourceForge/ } | ||
|
|
||
| context "when the Cask is not hosted on SourceForge" do |
Contributor
There was a problem hiding this comment.
For clarity, replace Cask by download here, too.
| end | ||
|
|
||
| describe "SourceForge appcast check" do | ||
| let(:error_msg) { /Cask hosted on SourceForge/ } |
Contributor
There was a problem hiding this comment.
Change this to :appcast_warning or :appcast_message to make your assertions more readable, and because it’s not an actual error.
claui
approved these changes
Jun 5, 2018
reitermarkus
approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?