Skip to content

Fix "unrecognized cop" warning in brew style#4301

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
apjanke:fix-rspec-rubocop-warning
Jun 7, 2018
Merged

Fix "unrecognized cop" warning in brew style#4301
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
apjanke:fix-rspec-rubocop-warning

Conversation

@apjanke
Copy link
Copy Markdown
Contributor

@apjanke apjanke commented Jun 7, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes an "unrecognized cop" warning by splitting out the RSpec-specific cop configuration to its own file that's only used when brew style --rspec is called.

Before:

$ brew style                                                                                                                                  master
Warning: unrecognized cop Rspec/ExpectActual found in .rubocop.yml
Warning: unrecognized cop Rspec/ExpectActual found in .rubocop.yml
Inspecting 657 files
..............................................................................................................................................................................

After:

$ brew style                                                                                                               fix-rspec-rubocop-warning
Inspecting 657 files
.......................................................................................................................................................................

Should probably be merged before doing any more rspec-rubocop configuration, to avoid even more warnings.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Nice! Thanks again @apjanke!

@MikeMcQuaid MikeMcQuaid merged commit 6a700cb into Homebrew:master Jun 7, 2018
@lock lock bot added the outdated PR was locked due to age label Jul 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants