Refactor brew cask search.#4306
Merged
reitermarkus merged 3 commits intoHomebrew:masterfrom Jun 8, 2018
Merged
Conversation
ghost
assigned
7 tasks
MikeMcQuaid
approved these changes
Jun 7, 2018
MikeMcQuaid
requested changes
Jun 7, 2018
Member
There was a problem hiding this comment.
What's this needed for? It'd be nice to instead move logic that's needed for a generalised brew integration test out of cask/lib.
Member
Author
There was a problem hiding this comment.
The generic stuff is already outside of cask/lib, but we cannot get around having access to the Cask class.
Member
There was a problem hiding this comment.
Ok. Can you see what overhead it adds to load this code (if any) on every brew process and brew tests integration test? Thanks!
Member
Author
There was a problem hiding this comment.
It doesn't load code, it only adds this path to the $LOAD_PATH.
MikeMcQuaid
approved these changes
Jun 7, 2018
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Refactor
brew cask searchonce more before merging it intobrew search.