text_cop: require cargo to use install instead of build

[commitay]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

Opened this for discussion, I'm still checking if all of the build formulae work as expected with install or if we would need to whitelist any.

Currently we prefer cargo install --root prefix (which doesn't need a bin.install) over cargo build. We have 27 formulae that run cargo, 18 have build and 9 have install.

[ilovezfs]

I don't think we can rule out the possibility of legitimately needing to run cargo build not cargo install.

[ilovezfs]

--root

[commitay]

Fixed

[commitay]

I don't think we can rule out the possibility of legitimately needing to run cargo build not cargo install.

Yeah, I guess it's possible. I haven't found any formulae that need build yet but I'm sure something will come along. Mostly wanted this to nudge new formulae to the preferred style but I suppose we could change all the formulae that we can to this style and hope people copy the right one?

[ilovezfs]

It looks like they're equivalent except that install defaults to a --release build whereas build defaults to a --debug build so I think we'll be OK.

[commitay]

Do you want PRs changing formulae to use install or just wait til they get bumped and fail audit?

[ilovezfs]

Voilà Homebrew/homebrew-core#28846

[ilovezfs]

Thanks @commitay!