Skip to content

formula_installer: don't pass spec arguments from ARGV to postinstall#4322

Merged
ilovezfs merged 1 commit intoHomebrew:masterfrom
ilovezfs:formula_installer-postinstall-spec
Jun 10, 2018
Merged

formula_installer: don't pass spec arguments from ARGV to postinstall#4322
ilovezfs merged 1 commit intoHomebrew:masterfrom
ilovezfs:formula_installer-postinstall-spec

Conversation

@ilovezfs
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Postinstall should be executed with the spec of the target formula not
the spec argument from ARGV, otherwise the prefix can be incorrect. In
other words, if the stable version of a dependency gets installed,
postinstall for the dependency should use the prefix of the dependency's
stable version, not the prefix of its devel or head version.

Fixes #2941.

Postinstall should be executed with the spec of the target formula not
the spec argument from ARGV, otherwise the prefix can be incorrect. In
other words, if the stable version of a dependency gets installed,
postinstall for the dependency should use the prefix of the dependency's
stable version, not the prefix of its devel or head version.

Fixes Homebrew#2941.
@ghost ghost assigned ilovezfs Jun 10, 2018
@ghost ghost added the in progress Maintainers are working on this label Jun 10, 2018
@MikeMcQuaid
Copy link
Copy Markdown
Member

Nice one! :shipit:

@ilovezfs ilovezfs merged commit 5614f11 into Homebrew:master Jun 10, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jun 10, 2018
@lock lock bot added the outdated PR was locked due to age label Jul 10, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

postinstall should determine prefix from spec not ARGV

2 participants