formula_installer: don't pass spec arguments from ARGV to postinstall#4322
Merged
ilovezfs merged 1 commit intoHomebrew:masterfrom Jun 10, 2018
Merged
Conversation
Postinstall should be executed with the spec of the target formula not the spec argument from ARGV, otherwise the prefix can be incorrect. In other words, if the stable version of a dependency gets installed, postinstall for the dependency should use the prefix of the dependency's stable version, not the prefix of its devel or head version. Fixes Homebrew#2941.
MikeMcQuaid
approved these changes
Jun 10, 2018
Member
|
Nice one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Postinstall should be executed with the spec of the target formula not
the spec argument from ARGV, otherwise the prefix can be incorrect. In
other words, if the stable version of a dependency gets installed,
postinstall for the dependency should use the prefix of the dependency's
stable version, not the prefix of its devel or head version.
Fixes #2941.