Skip to content

Add stderr output to exception.#4326

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:rubocop-stderr
Jun 11, 2018
Merged

Add stderr output to exception.#4326
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:rubocop-stderr

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Jun 11, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add error output to RuboCop exception. Otherwise Homebrew/homebrew-core#28873 is undebuggable.

@ghost ghost assigned reitermarkus Jun 11, 2018
@ghost ghost added the in progress Maintainers are working on this label Jun 11, 2018
@MikeMcQuaid
Copy link
Copy Markdown
Member

Good call, I've meant to do this in the past 👍. Thanks @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 0dd33fd into Homebrew:master Jun 11, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jun 11, 2018
@reitermarkus reitermarkus deleted the rubocop-stderr branch June 19, 2018 11:17
@lock lock bot added the outdated PR was locked due to age label Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants