Re-enable tests by removing a stray rspec :focus#4412
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Jul 2, 2018
claui:remove-rspec-focus
Merged
Re-enable tests by removing a stray rspec :focus#4412MikeMcQuaid merged 1 commit intoHomebrew:masterfrom claui:remove-rspec-focus
:focus#4412MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
claui:remove-rspec-focus
Conversation
MikeMcQuaid
approved these changes
Jul 2, 2018
Member
|
Thanks @claui!
There's an open issue to enable this by default but there's a bit of work needed to get there: #4058 |
Contributor
Author
|
@MikeMcQuaid Thanks for the pointer. I wasn’t aware of this issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Following in the tradition of #3006, this PR removes a stray
:focus. I only caught this because I ran a known-bad test by pure coincidence.Generally, I feel that those little pests are pretty hard to catch. I’m thinking of enabling a focus Cop so it’ll happen less often in the future. I also suggest to change test-bot so it runs
brew style --rspec.@Homebrew/maintainers Opinions?