Skip to content

Re-enable tests by removing a stray rspec :focus#4412

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
claui:remove-rspec-focus
Jul 2, 2018
Merged

Re-enable tests by removing a stray rspec :focus#4412
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
claui:remove-rspec-focus

Conversation

@claui
Copy link
Copy Markdown
Contributor

@claui claui commented Jul 2, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • (Does not apply) Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Following in the tradition of #3006, this PR removes a stray :focus. I only caught this because I ran a known-bad test by pure coincidence.

Generally, I feel that those little pests are pretty hard to catch. I’m thinking of enabling a focus Cop so it’ll happen less often in the future. I also suggest to change test-bot so it runs brew style --rspec.

@Homebrew/maintainers Opinions?

@ghost ghost assigned claui Jul 2, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 2, 2018
@claui claui added the discussion Input solicited from others label Jul 2, 2018
@MikeMcQuaid MikeMcQuaid merged commit ee1c206 into Homebrew:master Jul 2, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 2, 2018
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @claui!

Generally, I feel that those little pests are pretty hard to catch. I’m thinking of enabling a focus Cop so it’ll happen less often in the future. I also suggest to change test-bot so it runs brew style --rspec.

There's an open issue to enable this by default but there's a bit of work needed to get there: #4058

@claui claui deleted the remove-rspec-focus branch July 2, 2018 17:46
@claui
Copy link
Copy Markdown
Contributor Author

claui commented Jul 2, 2018

@MikeMcQuaid Thanks for the pointer. I wasn’t aware of this issue!

@claui claui removed the discussion Input solicited from others label Jul 2, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants