Conversation
ghost
assigned
|
|
||
| def stage | ||
| super | ||
| quiet_safe_system "svn", "export", "--force", cached_location, Dir.pwd |
There was a problem hiding this comment.
Why are these getting unquieted? In the previous PR you only unquieted those that had -q flags.
There was a problem hiding this comment.
Why are these getting unquieted?
These are not quiet currently. quiet_safe_system replaces i.e. { quiet_flag: '--quiet' }, which only cvs is using.
| cached = downloader.cached_location.exist? | ||
| downloader.fetch | ||
| ohai "Pouring the cached bottle" if cached | ||
| @bottle_filename = downloader.cached_location |
There was a problem hiding this comment.
What's the reordering about; does this change?
There was a problem hiding this comment.
This doesn't change anything at the moment, but this ordering is necessary for what I have in mind for refactoring the download locations.
Instead of relying on a somewhat hacky way to get the proper extension from a URL before downloading, we use no extension when initializing the download. We then know the actual file name after the download is finished, so in this case @bottle_filename should be set only after downloader.fetch has been called.
There was a problem hiding this comment.
So currently a cancelled download would have a correct extension – whether guessed in a "hacky" manner or not – and after the change a cancelled download would be extensionless? That sounds like a regression to me.
There was a problem hiding this comment.
What use does a correct extension have when the download is cancelled?
There was a problem hiding this comment.
Most of the downloads can be resumed – please do not remove that ability as it's very useful – but foo-1.2.3.tar.bz2.incomplete shouldn't be resumable if the extension changed from bz2 to xz. Also it's much more clear what a foo-1.2.3.tar.bz2.incomplete is than what a foo-1.2.3.incomplete is.
|
Thanks for explaining all the changes! Looks good to me. |
3 participants
brew stylewith your changes locally?brew testswith your changes locally?Clean up some things related to download strategies.