Skip to content

Remove MachO check for Executable.#4546

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:remove-macho-check
Jul 25, 2018
Merged

Remove MachO check for Executable.#4546
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:remove-macho-check

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Jul 25, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Remove MachO check for Executable.

Fixes #4541 (comment).

@reitermarkus reitermarkus requested a review from ilovezfs July 25, 2018 08:14
@ghost ghost assigned reitermarkus Jul 25, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 25, 2018
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern looking over this is wondering if it's still macOS-specific?

Copy link
Copy Markdown
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents the

/usr/local/Homebrew/Library/Homebrew/debrew.rb:11:in `raise'
MachO::MagicError: Unrecognized Mach-O magic: 0x46726f6d

@reitermarkus
Copy link
Copy Markdown
Member Author

My only concern looking over this is wondering if it's still macOS-specific?

It will end up defaulting to Uncompressed, which is the only thing that matters.

@MikeMcQuaid
Copy link
Copy Markdown
Member

It will end up defaulting to Uncompressed, which is the only thing that matters.

Cool 👍

@reitermarkus reitermarkus merged commit bfd82a3 into Homebrew:master Jul 25, 2018
@reitermarkus reitermarkus deleted the remove-macho-check branch July 25, 2018 08:28
@ghost ghost removed the in progress Maintainers are working on this label Jul 25, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants