Skip to content

Don’t rescue NameError for #run.#4547

Merged
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:fix-name_error
Jul 25, 2018
Merged

Don’t rescue NameError for #run.#4547
reitermarkus merged 1 commit intoHomebrew:masterfrom
reitermarkus:fix-name_error

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Only a NameError from const_get should be rescued, not one occurring in #run.

@reitermarkus reitermarkus requested a review from a team July 25, 2018 08:27
@ghost ghost assigned reitermarkus Jul 25, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 25, 2018
@reitermarkus reitermarkus merged commit a1f0ff4 into Homebrew:master Jul 25, 2018
@reitermarkus reitermarkus deleted the fix-name_error branch July 25, 2018 09:03
@ghost ghost removed the in progress Maintainers are working on this label Jul 25, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants