link: when refusing to link display keg only caveats instead.#4557
Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom Jul 26, 2018
MikeMcQuaid:no-link-caveats-output
Merged
link: when refusing to link display keg only caveats instead.#4557MikeMcQuaid merged 3 commits intoHomebrew:masterfrom MikeMcQuaid:no-link-caveats-output
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
MikeMcQuaid:no-link-caveats-output
Conversation
Let’s have a default value for shell (considering this isn’t a public API) to make it easier to use.
- make it a public method - allow skipping the reason - output how to set the various variables in your current shell
These are a bit easier to follow and have been recently improved. Inspired by conversation in #4441.
ghost
assigned
Contributor
|
Seems to behave as expected for me locally 👍. Thanks for looking at this! Definitely nicer to be able to lean on the caveat mechanism that already exists rather than duplicating the messaging, IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are a bit easier to follow and have been recently improved.
Inspired by conversation in #4441 CC @DomT4 @billinghamj
Also:
caveats: tweak keg_only_text
shell: tweak export_value parameters.
to make it easier to use.
Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run
brew stylewith your changes locally?Have you successfully run
brew testswith your changes locally?