Skip to content

Don’t match MZ for Cab.#4559

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
reitermarkus:fix-cab
Jul 27, 2018
Merged

Don’t match MZ for Cab.#4559
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
reitermarkus:fix-cab

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #4541 (comment).

@ghost ghost assigned reitermarkus Jul 26, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 26, 2018
default:
threshold: 0.1
default:
threshold: 0.05%
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do these changes relate to this PR?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The now required coverage check was failing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MikeMcQuaid MikeMcQuaid merged commit b335a73 into Homebrew:master Jul 27, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 27, 2018
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @reitermarkus!

@lock lock bot added the outdated PR was locked due to age label Aug 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2018
@reitermarkus reitermarkus deleted the fix-cab branch November 2, 2018 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants