Skip to content

diagnostic: refactor git origin checks and also check Cask origin#5764

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
jonchang:git-origins
Feb 22, 2019
Merged

diagnostic: refactor git origin checks and also check Cask origin#5764
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
jonchang:git-origins

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

c.f. https://discourse.brew.sh/t/issue-installing-recently-added-cask/4206/

This pull request refactors the git origin checks in brew doctor to use a common helper function, and also checks the Cask tap, if it exists, for a suspicious origin URL.

No tests written because the test framework doesn't use an actual git folder for its temporary repository.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

Comment thread Library/Homebrew/diagnostic.rb Outdated
Comment thread Library/Homebrew/diagnostic.rb Outdated
@MikeMcQuaid
Copy link
Copy Markdown
Member

@jonchang
Copy link
Copy Markdown
Contributor Author

Updated the wording to mirror each message. Will merge when green.

@MikeMcQuaid MikeMcQuaid merged commit 2f056da into Homebrew:master Feb 22, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @jonchang!

@jonchang jonchang deleted the git-origins branch February 23, 2019 04:06
@lock lock bot added the outdated PR was locked due to age label Mar 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants