Skip to content

Formula.installed: handle more exceptions.#5774

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:formula-installed-handle-standard-error
Feb 21, 2019
Merged

Formula.installed: handle more exceptions.#5774
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:formula-installed-handle-standard-error

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Feb 20, 2019

Regardless of the exception we don't want this method to blow up.

Fixes #5770.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Regardless of the exception we don't want this method to blow up.

Fixes #5770.
@MikeMcQuaid MikeMcQuaid merged commit 4a7934d into Homebrew:master Feb 21, 2019
@MikeMcQuaid MikeMcQuaid deleted the formula-installed-handle-standard-error branch February 21, 2019 12:28
@lock lock bot added the outdated PR was locked due to age label Mar 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant