Skip to content

Add varenc/ffmpeg to list of interesting taps#5818

Merged
fxcoudert merged 1 commit intoHomebrew:masterfrom
alebcay:patch-1
Mar 1, 2019
Merged

Add varenc/ffmpeg to list of interesting taps#5818
fxcoudert merged 1 commit intoHomebrew:masterfrom
alebcay:patch-1

Conversation

@alebcay
Copy link
Copy Markdown
Member

@alebcay alebcay commented Feb 28, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

It would be helpful to include this link in the list for users that wish to have custom-built versions of ffmpeg, especially with nonfree features enabled (which Homebrew cannot distribute), such as --with-fdk-aac.

@zbeekman
Copy link
Copy Markdown
Contributor

LGTM

@zbeekman
Copy link
Copy Markdown
Contributor

zbeekman commented Mar 1, 2019

I think someone from @Homebrew/brew needs to do the merging here. On a related note, I think I'm comfortable enough with my newly acquired Ruby skills, and understanding of the work flows to be added to the brew team if others are comfortable/cool with it. Happy either way.

@fxcoudert fxcoudert merged commit cf354e7 into Homebrew:master Mar 1, 2019
@lock lock bot added the outdated PR was locked due to age label Mar 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants