Skip to content

Add "bottle_disabled" to brew info --json#5903

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
native-api:show_bottle_disabled
Mar 23, 2019
Merged

Add "bottle_disabled" to brew info --json#5903
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
native-api:show_bottle_disabled

Conversation

@native-api
Copy link
Copy Markdown
Contributor

@native-api native-api commented Mar 21, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • N/A Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Subj, as suggested in https://discourse.brew.sh/t/how-to-detect-if-formula-has-disabled-bottling/4431/3?u=native-api . This flag is set in both cases of bottle :disabled and bottle :unneeded.

@native-api
Copy link
Copy Markdown
Contributor Author

native-api commented Mar 21, 2019

The failures are unrelated and caused by eabdbde

@MikeMcQuaid MikeMcQuaid merged commit 891c67d into Homebrew:master Mar 23, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @native-api!

@native-api
Copy link
Copy Markdown
Contributor Author

Ah, you flatter me! 😊

@native-api native-api deleted the show_bottle_disabled branch March 23, 2019 11:47
@lock lock bot added the outdated PR was locked due to age label Apr 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants