Skip to content

Update Prose-Style-Guidelines.md#5904

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SFU-TechnicalWriter:patch-1
Mar 22, 2019
Merged

Update Prose-Style-Guidelines.md#5904
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
SFU-TechnicalWriter:patch-1

Conversation

@SFU-TechnicalWriter
Copy link
Copy Markdown
Contributor

Some users may not understand the usage of the word “trump” in this context, and therefore simpler words could be used without changing the meaning.

  • [ x] Have you followed the guidelines in our Contributing document?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ x] Have you written new tests for your changes? Here's an example.
  • [x ] Have you successfully run brew style with your changes locally?
  • [x ] Have you successfully run brew tests with your changes locally?

Some users may not understand the usage of the word “trump” in this context, and therefore alternative words could be used.
@MikeMcQuaid MikeMcQuaid merged commit 4836be3 into Homebrew:master Mar 22, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks so much for your first contribution (hopefully of many)! Without people like you submitting PRs we couldn't run this project. You rock, @SFU-TechnicalWriter!

@lock lock bot added the outdated PR was locked due to age label Apr 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants