Skip to content

cask: improve JSON output consistency.#5939

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:cask-json-consistency
Mar 28, 2019
Merged

cask: improve JSON output consistency.#5939
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:cask-json-consistency

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Mar 27, 2019

Replace the use of HOME or HOMEBREW_PREFIX in the output strings with variable versions. This is particularly useful on formulae.brew.sh.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • [x Have you successfully run brew tests with your changes locally?

Replace the use of HOME or HOMEBREW_PREFIX in the output strings with
variable versions. This is particularly useful on formulae.brew.sh.
@MikeMcQuaid MikeMcQuaid merged commit 9dc19e8 into Homebrew:master Mar 28, 2019
@MikeMcQuaid MikeMcQuaid deleted the cask-json-consistency branch March 28, 2019 19:11
@lock lock bot added the outdated PR was locked due to age label Apr 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant