Skip to content

Cleanup some RSpec tests#5944

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:rubocop-specs-cleanup
Mar 28, 2019
Merged

Cleanup some RSpec tests#5944
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:rubocop-specs-cleanup

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Fix some Rubocop RSpec checks, update some values and improve documentation.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix some Rubocop RSpec checks, update some values and improve
documentation.
@MikeMcQuaid MikeMcQuaid merged commit f1f792e into Homebrew:master Mar 28, 2019
@MikeMcQuaid MikeMcQuaid deleted the rubocop-specs-cleanup branch March 28, 2019 19:57
@lock lock bot added the outdated PR was locked due to age label Apr 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant