Skip to content

Force GET for head requests.#5978

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:head-get
Apr 3, 2019
Merged

Force GET for head requests.#5978
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:head-get

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

@reitermarkus reitermarkus commented Apr 3, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #5895.

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Didn't know you could do this, TIL!

@reitermarkus
Copy link
Copy Markdown
Member Author

I didn't either, just made a wild guess. 😃

@MikeMcQuaid
Copy link
Copy Markdown
Member

@reitermarkus In case you didn't see #5977 was also merged but I think both changes, although not necessary, make more sense in avoiding stuff like this in future.

@reitermarkus
Copy link
Copy Markdown
Member Author

Yeah, you beat me by a minute. Two fixes are better than one. 😉

@MikeMcQuaid
Copy link
Copy Markdown
Member

For full disclosure: I also did a quick check of the codebase to see if we're using --head or -I inappropriately anywhere else and couldn't see anywhere 👍

@MikeMcQuaid MikeMcQuaid merged commit 1aa5e1e into Homebrew:master Apr 3, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks @reitermarkus ❤️

@reitermarkus reitermarkus deleted the head-get branch April 3, 2019 11:05
@lock lock bot added the outdated PR was locked due to age label May 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't install atlassian-cli

2 participants