Force GET for head requests.#5978
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Apr 3, 2019
Merged
Conversation
MikeMcQuaid
approved these changes
Apr 3, 2019
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Nice. Didn't know you could do this, TIL!
Member
Author
|
I didn't either, just made a wild guess. 😃 |
Member
|
@reitermarkus In case you didn't see #5977 was also merged but I think both changes, although not necessary, make more sense in avoiding stuff like this in future. |
Member
Author
|
Yeah, you beat me by a minute. Two fixes are better than one. 😉 |
Member
|
For full disclosure: I also did a quick check of the codebase to see if we're using |
Member
|
Thanks @reitermarkus ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Fixes #5895.