Skip to content

Fix support for HOMEBREW_EDITOR with args.#5982

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:editor-args
Apr 4, 2019
Merged

Fix support for HOMEBREW_EDITOR with args.#5982
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
reitermarkus:editor-args

Conversation

@reitermarkus
Copy link
Copy Markdown
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes regression in #5942.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks for the fix @reitermarkus and sorry for the breakage!

@MikeMcQuaid MikeMcQuaid merged commit 55b4522 into Homebrew:master Apr 4, 2019
@lock lock bot added the outdated PR was locked due to age label May 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2019
@reitermarkus reitermarkus deleted the editor-args branch August 19, 2019 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants