Skip to content

Freeze more mutable constants.#6039

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:freeze-mutable-objects
Apr 19, 2019
Merged

Freeze more mutable constants.#6039
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:freeze-mutable-objects

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than too
little).

Also, fix mutable constants violations.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include thex?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than
too little).
@MikeMcQuaid MikeMcQuaid merged commit efa60e4 into Homebrew:master Apr 19, 2019
@MikeMcQuaid MikeMcQuaid deleted the freeze-mutable-objects branch April 19, 2019 23:26
@lock lock bot added the outdated PR was locked due to age label May 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant