Freeze more mutable constants.#6039
Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom Apr 19, 2019
MikeMcQuaid:freeze-mutable-objects
Merged
Freeze more mutable constants.#6039MikeMcQuaid merged 2 commits intoHomebrew:masterfrom MikeMcQuaid:freeze-mutable-objects
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
MikeMcQuaid:freeze-mutable-objects
Conversation
This rule adjustment is experimental in RuboCop as it may double-freeze objects but this isn't an error (and freezing too much is better than too little).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than too
little).
Also, fix mutable constants violations.
brew stylewith your changes locally?brew testswith your changes locally?