Skip to content

Add doc of HOMEBREW_ARCH#6102

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
dalance:homebrew_arch_doc
May 7, 2019
Merged

Add doc of HOMEBREW_ARCH#6102
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
dalance:homebrew_arch_doc

Conversation

@dalance
Copy link
Copy Markdown
Contributor

@dalance dalance commented May 7, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I added a document of HOMEBREW_ARCH added by #6098.
My English is not native, please indicate any mistake.

Copy link
Copy Markdown
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the source file located at Library/Homebrew/manpages/brew.1.md.erb. Then run brew man to generate manpages and markdown documentation and commit the result.

@dalance dalance force-pushed the homebrew_arch_doc branch from 1b94a95 to cb99dea Compare May 7, 2019 02:48
@dalance dalance force-pushed the homebrew_arch_doc branch from cb99dea to 9d4e1a5 Compare May 7, 2019 02:50
@dalance
Copy link
Copy Markdown
Contributor Author

dalance commented May 7, 2019

Thanks. I fixed it.

@MikeMcQuaid MikeMcQuaid dismissed jonchang’s stale review May 7, 2019 07:34

Comment addressed

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your further contribution! Without people like you submitting PRs we couldn't run this project. You rock, @dalance!

@MikeMcQuaid MikeMcQuaid merged commit 4141c1b into Homebrew:master May 7, 2019
@dalance
Copy link
Copy Markdown
Contributor Author

dalance commented May 7, 2019

Thank you for your review.

@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants