Skip to content

pkgconfig: add uuid.pc#6120

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
tschoonj:uuid-pkgconfig
May 12, 2019
Merged

pkgconfig: add uuid.pc#6120
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
tschoonj:uuid-pkgconfig

Conversation

@tschoonj
Copy link
Copy Markdown
Contributor

@tschoonj tschoonj commented May 12, 2019

The util-linux uuid library is provided by macOS, through its header at
/usr/include/uuid/uuid.h, and implementation included in libSystem.B.dylib
Using this it is possible to reduce dependency on the unmaintained ossp-uuid formula in a couple of cases.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The util-linux uuid library is provided by macOS, through its header at
/usr/include/uuid/uuid.h, and implementation included in libSystem.B.dylib
@tschoonj
Copy link
Copy Markdown
Contributor Author

Are unit tests necessary for this kind of change?

@MikeMcQuaid
Copy link
Copy Markdown
Member

Are unit tests necessary for this kind of change?

Nope! Looks good, thanks again @tschoonj!

@MikeMcQuaid MikeMcQuaid merged commit 8e773f9 into Homebrew:master May 12, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants