Skip to content

docs/Formula-Cookbook: add more details to tests#6169

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Moisan:doc_tests_details
May 24, 2019
Merged

docs/Formula-Cookbook: add more details to tests#6169
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Moisan:doc_tests_details

Conversation

@Moisan
Copy link
Copy Markdown
Member

@Moisan Moisan commented May 24, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@fxcoudert made some good comments on writing tests in this PR. I think we can improve the documentation with them. I also added a couple examples.

@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks both of you!

@MikeMcQuaid MikeMcQuaid merged commit 11b24b3 into Homebrew:master May 24, 2019
@Moisan Moisan deleted the doc_tests_details branch May 24, 2019 13:22
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants