Skip to content

Ruby 2.6 frozen string literals#6687

Merged
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
jonchang:frozen-string-literal
Nov 4, 2019
Merged

Ruby 2.6 frozen string literals#6687
MikeMcQuaid merged 2 commits intoHomebrew:masterfrom
jonchang:frozen-string-literal

Conversation

@jonchang
Copy link
Copy Markdown
Contributor

@jonchang jonchang commented Nov 4, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Updates the last two files to use frozen_string_literal: true. Also updates a Ruby version check in brew.rb.

Now that we use Ruby 2.6 we can fix these last two files.
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@MikeMcQuaid MikeMcQuaid merged commit 33330ba into Homebrew:master Nov 4, 2019
@jonchang jonchang deleted the frozen-string-literal branch November 4, 2019 10:36
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants