Skip to content

cmd/upgrade: comment-out broken_dependents functionality.#6693

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:comment_broken_dependents
Nov 5, 2019
Merged

cmd/upgrade: comment-out broken_dependents functionality.#6693
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:comment_broken_dependents

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

This is not a fix for #6671 but will stop people hitting this bug for now.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@jonchang
Copy link
Copy Markdown
Contributor

jonchang commented Nov 5, 2019

Can we put this behind a feature flag instead? I've been trying a few things to maybe repro this on my laptop.

@jonchang
Copy link
Copy Markdown
Contributor

jonchang commented Nov 5, 2019

Never mind, I actually can just branch it since I'm inserting logging code anyway. 👍

This is not a fix for #6671 but
will stop people hitting this bug for now.
@MikeMcQuaid MikeMcQuaid merged commit 3aa7624 into Homebrew:master Nov 5, 2019
@MikeMcQuaid MikeMcQuaid deleted the comment_broken_dependents branch November 5, 2019 10:11
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants