cmd/upgrade: comment-out broken_dependents functionality.#6693
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Nov 5, 2019
MikeMcQuaid:comment_broken_dependents
Merged
cmd/upgrade: comment-out broken_dependents functionality.#6693MikeMcQuaid merged 1 commit intoHomebrew:masterfrom MikeMcQuaid:comment_broken_dependents
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:comment_broken_dependents
Conversation
Contributor
|
Can we put this behind a feature flag instead? I've been trying a few things to maybe repro this on my laptop. |
Contributor
|
Never mind, I actually can just branch it since I'm inserting logging code anyway. 👍 |
This is not a fix for #6671 but will stop people hitting this bug for now.
jonchang
approved these changes
Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a fix for #6671 but will stop people hitting this bug for now.
brew stylewith your changes locally?brew testswith your changes locally?