Skip to content

upgrade: fix handling broken dependents.#6720

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:upgrade-broken-fix
Nov 11, 2019
Merged

upgrade: fix handling broken dependents.#6720
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:upgrade-broken-fix

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

Ensure that we use the keg for checking linkage but that the dependents returned are still formulae.

Thanks to @scpeters for help in #6698 (review)

Fixes #6715.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Ensure that we use the keg for checking linkage but that the dependents
returned are still formulae.

Fixes #6715.
@MikeMcQuaid MikeMcQuaid merged commit 20cf2af into Homebrew:master Nov 11, 2019
@MikeMcQuaid MikeMcQuaid deleted the upgrade-broken-fix branch November 11, 2019 11:37
@scpeters
Copy link
Copy Markdown
Contributor

looks good to me

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: undefined method 'outdated?' for #<Keg:/usr/local/Cellar/hydra/9.0_1.reinstall>

2 participants