Skip to content

Update brew.sh: hide printf's stderr in numeric()#6722

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
evgkrsk:patch-1
Nov 12, 2019
Merged

Update brew.sh: hide printf's stderr in numeric()#6722
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
evgkrsk:patch-1

Conversation

@evgkrsk
Copy link
Copy Markdown
Contributor

@evgkrsk evgkrsk commented Nov 11, 2019

Avoid #6721 and similar confusing messages during version comparison by hiding printf's stderr (printf woks anyway).

  • [+] Have you followed the guidelines in our Contributing document?
  • [+] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [+] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [-] Have you written new tests for your changes? Here's an example.
  • [+] Have you successfully run brew style with your changes locally?
  • [+] Have you successfully run brew tests with your changes locally?

Avoid #6721 and similar confusing messages during version comparison by hiding printf's stderr (printf woks anyway).
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @evgkrsk!

@MikeMcQuaid MikeMcQuaid merged commit 2e0c703 into Homebrew:master Nov 12, 2019
@evgkrsk evgkrsk deleted the patch-1 branch November 12, 2019 07:02
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants