Skip to content

Fix Audit check for env :std#6738

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dunkmann00:audit_env
Nov 14, 2019
Merged

Fix Audit check for env :std#6738
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
dunkmann00:audit_env

Conversation

@dunkmann00
Copy link
Copy Markdown
Contributor

When performing a strict audit of a formula in the core tap, it was
possible that the check for env :std would not happen.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This fixes the strict audit, making sure that if the formula is part of core, brew audit --strict checks to see if env :std is used.

This references #6737.

@scpeters
Copy link
Copy Markdown
Contributor

Nice catch!

Given that the return unless disguised this issue, do you mind changing return unless line.include?("env :std") as well to use an if statement?

@dunkmann00
Copy link
Copy Markdown
Contributor Author

Sure thing! Should I squash the 2 commits together?

@MikeMcQuaid
Copy link
Copy Markdown
Member

Yes please!

When performing a strict audit of a formula in the core tap, it was
possible that the check for `env :std` would not happen.
@MikeMcQuaid MikeMcQuaid merged commit 1b92638 into Homebrew:master Nov 14, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @dunkmann00!

@dunkmann00
Copy link
Copy Markdown
Contributor Author

Thanks!

@dunkmann00 dunkmann00 deleted the audit_env branch November 14, 2019 02:20
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants