Fix Audit check for env :std#6738
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Nov 14, 2019
Merged
Conversation
Contributor
|
Nice catch! Given that the |
Contributor
Author
|
Sure thing! Should I squash the 2 commits together? |
Member
|
Yes please! |
When performing a strict audit of a formula in the core tap, it was possible that the check for `env :std` would not happen.
1893fe8 to
8221e32
Compare
scpeters
approved these changes
Nov 14, 2019
Member
|
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @dunkmann00! |
Contributor
Author
|
Thanks! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing a strict audit of a formula in the core tap, it was
possible that the check for
env :stdwould not happen.brew stylewith your changes locally?brew testswith your changes locally?This fixes the strict audit, making sure that if the formula is part of core,
brew audit --strictchecks to see ifenv :stdis used.This references #6737.