Skip to content

formula: copy hidden files _from_ bottles.#6744

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:bottle-dotfiles
Nov 15, 2019
Merged

formula: copy hidden files _from_ bottles.#6744
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
Bo98:bottle-dotfiles

Conversation

@Bo98
Copy link
Copy Markdown
Member

@Bo98 Bo98 commented Nov 14, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

In #6708 I fixed a situation where hidden files in etc or var were not copied into bottles. And that has worked. I can confirm the MariaDB bottles all now have .homebrew_dont_prune_me. I thought it already was working copying from bottles as well - and I wasn't alone in that (see Homebrew/homebrew-core#46252 in which another user confirmed installing the new bottles worked).

I've discovered a case however, on clean installs, that those files might not be copied from the bottle, which I hope to fix here.

The situation is very similar to the other pull request: glob doesn't return dotfiles while find does.

@MikeMcQuaid MikeMcQuaid merged commit a59be43 into Homebrew:master Nov 15, 2019
@MikeMcQuaid
Copy link
Copy Markdown
Member

Thanks again @Bo98!

@Bo98 Bo98 deleted the bottle-dotfiles branch November 15, 2019 00:35
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants