Upped the timeout for curl to 15 seconds to match other code#6750
Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom Nov 20, 2019
fuddlesworth:curl-fix
Merged
Upped the timeout for curl to 15 seconds to match other code#6750MikeMcQuaid merged 1 commit intoHomebrew:masterfrom fuddlesworth:curl-fix
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
fuddlesworth:curl-fix
Conversation
MikeMcQuaid
approved these changes
Nov 20, 2019
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Seems reasonable! Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @MrKumaPants!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?The default
--connect-timeout=5argument for curl is too small and is preventing many packages from properly installing.The default value also does not match the
--connect-timeoutvalue in other places show here.