Skip to content

Fix brew cask style.#6794

Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
MikeMcQuaid:fix-cask-style
Dec 1, 2019
Merged

Fix brew cask style.#6794
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
MikeMcQuaid:fix-cask-style

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Dec 1, 2019

This was broken by a RuboCop update. As this was broken and not noticed: add tests to ensure that this can't happen in future and re-enable warnings so that users can better figure out what's gone wrong.

Fixes Homebrew/homebrew-cask#73411

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These sometimes display useful RuboCop deprecations.
Broken since a RuboCop update.
This verifies the cask configuration hasn't been broken.
@MikeMcQuaid MikeMcQuaid merged commit fcfa80a into Homebrew:master Dec 1, 2019
@MikeMcQuaid MikeMcQuaid deleted the fix-cask-style branch December 1, 2019 15:19
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cask style checks failing

1 participant