cmd/dev-cmd: improve handling of invalid input#6835
cmd/dev-cmd: improve handling of invalid input#6835MikeMcQuaid merged 6 commits intoHomebrew:masterfrom
Conversation
33ab0fd to
68244cf
Compare
There was a problem hiding this comment.
I wonder if adding a new exception for this specific case would be a good idea (or even an argument to #parse`) ?
There was a problem hiding this comment.
I took a shot at implementing this in cli/parser; have a look.
There was a problem hiding this comment.
Similarly: a new exception or an argument to #parse` might be a better fit?
68244cf to
30e4bbe
Compare
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Amazing work, love where this is going.
There was a problem hiding this comment.
Could/should this be a FormulaUnspecifiedError?
There was a problem hiding this comment.
I made these a UsageError with a custom message stating that a formula argument is required only for these specific flags, rather than the command in general, as is implied in the wording of FormulaUnspecifiedError.
30e4bbe to
aea6d79
Compare
|
Fantastic work as usual @EricFromCanada! |
brew stylewith your changes locally?brew testswith your changes locally?Raises errors in more cases of missing or invalid input for various commands. Includes improvements for wording and help text.