Skip to content

ARGV: Replace usages of ARGV.named with Homebrew.args.named#6840

Merged
GauthamGoli merged 1 commit intoHomebrew:masterfrom
GauthamGoli:argv-cleanup-6
Dec 18, 2019
Merged

ARGV: Replace usages of ARGV.named with Homebrew.args.named#6840
GauthamGoli merged 1 commit intoHomebrew:masterfrom
GauthamGoli:argv-cleanup-6

Conversation

@GauthamGoli
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [] Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5730

Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggested style changes but nothing blocking. Nice work!

Comment thread Library/Homebrew/cli/args.rb Outdated
Comment thread Library/Homebrew/cmd/list.rb Outdated
Comment thread Library/Homebrew/cmd/list.rb Outdated
Comment thread Library/Homebrew/cmd/list.rb Outdated
Comment thread Library/Homebrew/cmd/migrate.rb Outdated
Comment thread Library/Homebrew/cmd/--cellar.rb Outdated
Comment thread Library/Homebrew/cmd/--prefix.rb Outdated
Comment thread Library/Homebrew/cmd/info.rb Outdated
Comment thread Library/Homebrew/cmd/info.rb Outdated
Comment thread Library/Homebrew/cmd/info.rb Outdated
@GauthamGoli GauthamGoli merged commit 2749c52 into Homebrew:master Dec 18, 2019
@GauthamGoli GauthamGoli deleted the argv-cleanup-6 branch December 18, 2019 19:18
@lock lock bot added the outdated PR was locked due to age label Jan 17, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants