Skip to content

uses_from_macos: remove before/after.#6859

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:uses_from_macos_remove_before_after
Dec 19, 2019
Merged

uses_from_macos: remove before/after.#6859
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:uses_from_macos_remove_before_after

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Dec 19, 2019

We're not actually using this anywhere and it makes the code more complicated.

Relatedly, this PR fixes the issue where uses_from_macos "python@2" => :build was valid on macOS but not on Linux.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
uses_from_macos: remove before/after.
0c1b556 
We're not actually using this anywhere and it makes the code
more complicated.

Relatedly, this PR fixes the issue where
`uses_from_macos "python@2" => :build` was valid on macOS but not
on Linux.
@MikeMcQuaid MikeMcQuaid mentioned this pull request Dec 19, 2019
Merged
@MikeMcQuaid MikeMcQuaid merged commit 08cc557 into Homebrew:master Dec 19, 2019
@MikeMcQuaid MikeMcQuaid deleted the uses_from_macos_remove_before_after branch December 19, 2019 15:01
@lock lock bot added the outdated PR was locked due to age label Jan 18, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MikeMcQuaid