Skip to content

utils/github: refactor and update logic.#6915

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:github-api-credentials
Jan 10, 2020
Merged

utils/github: refactor and update logic.#6915
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:github-api-credentials

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Jan 9, 2020 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
utils/github: refactor and update logic.
8ad50cd 
- better handle `HOMEBREW_GITHUB_API_USERNAME` and
  `HOMEBREW_GITHUB_API_PASSWORD` from `brew gist-logs`
- only user personal access tokens from the macOS keychain (fixes #6862)
- general refactoring and cleanup around the above
@MikeMcQuaid MikeMcQuaid merged commit 4a49499 into Homebrew:master Jan 10, 2020
@MikeMcQuaid MikeMcQuaid deleted the github-api-credentials branch January 10, 2020 12:17
@lock lock bot added the outdated PR was locked due to age label Feb 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated PR was locked due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Homebrew GitHub API Access Should Not Use Password Authentication

1 participant

@MikeMcQuaid