Skip to content

Improve handling of *_GIT_REMOTE env vars#6929

Merged
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:improve_git_remote
Jan 13, 2020
Merged

Improve handling of *_GIT_REMOTE env vars#6929
MikeMcQuaid merged 1 commit intoHomebrew:masterfrom
MikeMcQuaid:improve_git_remote

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented Jan 13, 2020

  • Output a message whenever a non-default remote is set.
  • Ensure that CoreTap.instance.install uses the right remote.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- Output a message whenever a non-default remote is set.
- Ensure that `CoreTap.instance.install` uses the right remote.
@MikeMcQuaid MikeMcQuaid merged commit 1640d96 into Homebrew:master Jan 13, 2020
@MikeMcQuaid MikeMcQuaid deleted the improve_git_remote branch January 13, 2020 13:50
@lock lock bot added the outdated PR was locked due to age label Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant