Catalina upgrades causes Homebrew to break when you run brew cleanup.…

[rogerhu]

Catalina has Ruby 2.6 installed, so the portable Ruby version is not needed.

If you have /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby (which exists for older OS X versions), then the cleanup tool will nuke everything in /usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby.

Traceback (most recent call last):
	4: from /usr/local/Homebrew/Library/Homebrew/brew.rb:23:in `<main>'
	3: from /usr/local/Homebrew/Library/Homebrew/brew.rb:23:in `require_relative'
	2: from /usr/local/Homebrew/Library/Homebrew/global.rb:13:in `<top (required)>'
	1: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot load such file -- active_support/core_ext/object/blank (LoadError)

You will need to brew update-reset to get back the old packages.

Trying to get feedback on why we're nuking vendor_path code. Can we get rid of it?

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[MikeMcQuaid]

You're right that this code is (now) incorrect. It is needed when you change between portable and system Ruby, though, because otherwise natively compiled Ruby modules will crash.

[MikeMcQuaid]

Instead this should run safe_system "git", "clean", "-xf", bundler_path

[rogerhu]

Done!

[MikeMcQuaid]

Instead this should run puts "Would remove:\n#{Utils.popen_read("git", "clean", "-xnf", bundler_path)}

[rogerhu]

Fixed!

[MikeMcQuaid]

Merged in #6942.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @rogerhu!

[rogerhu]

Thanks for your quick turnaround! (and for updating the unit tests)

[rogerhu]

Possible you can do a hot-fix release for this fix? We at squareup.com use an internal tool that invokes brew cleanup and it causes a lot of issues for Catalina upgrades. We can add a workaround if the timing's not right for you so please let us know! Thanks!

[MikeMcQuaid]

@rogerhu Sorry, no. We should do a release early next week (perhaps even Monday afternoon UK time) but this depends a lot on what's going on.