help: print cli/parser help message if used#6965
Merged
MikeMcQuaid merged 6 commits intoHomebrew:masterfrom Feb 1, 2020
Merged
help: print cli/parser help message if used#6965MikeMcQuaid merged 6 commits intoHomebrew:masterfrom
MikeMcQuaid merged 6 commits intoHomebrew:masterfrom
Conversation
2965581 to
e9274b3
Compare
Member
|
Thanks, Dawid! This works for me. Here's the before/after: |
MikeMcQuaid
requested changes
Jan 27, 2020
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Nice work, we should definitely do something like this.
MikeMcQuaid
approved these changes
Feb 1, 2020
Member
|
Thanks @dawidd6! |
This was referenced Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?External commands using
cli/parsercurrently can't produce a valid help message, becausebrewlooks for#:comments on top of the command file. With this patch, it becomes possible to get the help message normally.Discussion on the issue here: https://github.com/Homebrew/homebrew-linux-dev/pull/137